Small refactoring of Wait* commands 🐏 #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
vdemeester
force-pushed
the
refactoring-wait
branch
from
a6df8cf
to
2d0a8c8
Compare
tekton-robot
added
size/L
vdemeester
force-pushed
the
refactoring-wait
branch
from
2d0a8c8
to
86bdaf4
Compare
This makes WaitFor* with pipeline resource more generic, you can use `Succeed` or `Failed` with `WaitForPipelineRunState` and `WaitForTaskrRunState`. This reduces some duplication. Keeping the old function so that we don't need to fix all those call at the current time. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
refactoring-wait
branch
from
86bdaf4
to
37dee65
Compare
ghost
approved these changes
Mar 20, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
tekton-robot
added
the
approved
afrittoli
added
the
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This makes WaitFor* with pipeline resource more generic, you can use
SucceedorFailedwithWaitForPipelineRunStateandWaitForTaskrRunState.This reduces some duplication. Keeping the old function so that we
don't need to fix all those call at the current time.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.